SNOW-3061745: Propagate parameter bindings in nested CALL operations#4192
Merged
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4192 +/- ##
=======================================
Coverage 95.17% 95.17%
=======================================
Files 171 171
Lines 43801 43801
Branches 7505 7505
=======================================
+ Hits 41686 41687 +1
+ Misses 1294 1293 -1
Partials 821 821 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
27c6c9f to
003d251
Compare
sfc-gh-bkogan
approved these changes
Apr 22, 2026
003d251 to
898e394
Compare
sfc-gh-mayliu
approved these changes
Apr 28, 2026
sfc-gh-mayliu
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, seems like some AI function tests are failing due to deprecated models though
e02db80 to
f71952d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-3061745
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Fixes an issue where DESCRIBE queries for CALL queries with parameter bindings were raising an error. This occurred because internal DESCRIBE calls to
analyze_attributeswere not passing query parameters with certain chained operations.High-level control flow (generated by cursor):